Remove Ember.String.fmt

[locks]

No description provided.

[rwjblue]

Seems good to me. We need to ensure this functionality sticks around when you have ember-2-legacy addon installed, but its super easy to just move the implementation over there.

Can you make an issue over on https://github.com/emberjs/ember-2-legacy to add support to add these back when the legacy addon is present? I just don't want to lose track...

[sduquej]

_fmt is used in loc:

ember.js/packages/ember-runtime/lib/system/string.js

Lines 81 to 88 in a7518b9

	function loc(str, formats) {
	if (!isArray(formats) || arguments.length > 2) {
	formats = Array.prototype.slice.call(arguments, 1);
	}
	str = getString(str) || str;
	return _fmt(str, formats);
	}

and fmt is referenced in the documentation for it.

Think we'll need to update these too. (Happy to help with this in any way)

[lorcan]

Ember.String.loc also depends on the same functionality of Ember.String.fmt. Is there a case for deprecating Ember.String.loc? Too late for 3.0.0, but worth flagging?

[locks]

@lorcan thanks for the review. loc is already deprecated by RFC 236, and you can follow the implementation of this deprecation in #15624.
As mentioned in The Road to Ember 3.0, "No additional 3.0-targeted deprecations will be introduced."

If we manage to finish all the Ember.String work soon, the deprecation should land in the 3.x series, with an until of 4.0.0.