[BUGFIX release] Fix rendering a property of a function #15535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased and focused version of #15482 on just the regression. Before 2.10 you could render a property of a function, but you couldn't notify it updated. This should make its way into the LTS since this regressed in 2.10 /cc @rwjblue @locks It is simple to support updates too, I just don't think it should be back ported since it wasn't possible before. |
rwjblue
approved these changes
Jul 21, 2017
|
|
||
| this.assertStableRerender(); | ||
|
|
||
| // this.runTask(() => set(func, 'aProp', 'still a property on a function')); |
There was a problem hiding this comment.
because I missed that? I didn't comment it out.
There was a problem hiding this comment.
The test was trying to do INUR (which is likely what prompted the fixing of the updating side also), so my guess is that the update/reset parts here are just commented out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.