Commits on Aug 1, 2017

1. Remove ControllerContentModelAliasDeprecation for deprecatingAlias …

   So, this is kind of a fun one.
   
   From what I can tell, `ControllerContentModelAliasDeprecation` was
   introduced, due to Controllers having a `content` property, which
   `model` was aliased to.
   This was done because `ObjectController` and `ArrayController`
   were proxying controllers.
   
   But, in Ember, routes set up the `model` property of its respective
   controller.
   What this meant is that if someone declared a `content` property
   in their controller, `model` would—seemingly unrelated—break,
   hence the `ControllerContentModelAliasDeprecation` mixin.
   
   Nowadays it is fine to override `content` because the source of
   truth was reverse, and `model` is now the primary property, being
   `content` the alias.
   It is, then, time to remove the old deprecation and instead
   deprecate the alias itself, so that in the future users can define
   a `content` property in their controllers if they so desire.
   
   Another API bites the dust.
   Here's to removing yet more code in the future, and make Ember
   sparkle-clean.

   

   locks committed Aug 1, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 2058272
   • Browse repository at this point

   Copy the full SHA

   2058272 View commit details

   Browse the repository at this point in the history