Add missing instrumentation for compilation/lookup phase #15085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpadilla
force-pushed
the
ember-instrument-compiliation
branch
from
52628b3
to
99cca3e
Compare
…efined definition
mmun
requested changes
Mar 28, 2017
| return this._definitionCache.get({ name, source, owner }); | ||
| let definition = this._definitionCache.get({ name, source, owner }); | ||
| if (definition) { | ||
| definition.finalizer = finalizer; |
There was a problem hiding this comment.
@mixonic notes that this may not work as expected if the same component is used multiple times.
| definition.finalizer = finalizer; | ||
| } else { | ||
| finalizer(); | ||
| } |
There was a problem hiding this comment.
It's not clear that two control flows (with and without definition) are being weighed the same way. @rwjblue suggests always calling the finalizer at the end of the is method, and changing the instrumentation identifier to something more specific like 'render.getComponentDefinition' and then add other separate instrumentations for other parts of the code.
|
Just pushed changes based on feedback from Merge Party at EmberConf |
|
@mmun are you good with the improvements? |
mmun
approved these changes
Apr 5, 2017
|
@mmun @stefanpenner awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this for further discussion and feedback. Aims to fix #14974
cc: @paddyobrien @ghedamat