Default the template helper test blueprint to integration style #14970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in favor of making |
rondale-sc
force-pushed
the
default-helper-test-to-integration
branch
2 times, most recently
from
c98e402
to
4daf0ca
Compare
|
Does this impact the testing guides? |
|
@locks looks like the unit testing section in the testing guide uses models as the de facto unit test. I'm not sure if we'd see problems with this change elsewhere. Regardless I'm having a little bit of difficulty figuring out these last few failures. Hopefully will be able to spend some time on them tomorrow. |
rondale-sc
force-pushed
the
default-helper-test-to-integration
branch
from
4daf0ca
to
9ace9fe
Compare
|
I believe this should pass now, but not sure if it is retriggering a build. 🤔 |
|
Seems likely that the delay/issue is related to AWS issues (see https://www.traviscistatus.com/ for details). |
rondale-sc
force-pushed
the
default-helper-test-to-integration
branch
from
9ace9fe
to
73411d0
Compare
|
Rebased against master and that triggered the build. 🎉 |
rwjblue
approved these changes
Mar 3, 2017
|
LGTM, @stefanpenner r? |
locks
approved these changes
Mar 4, 2017
stefanpenner
approved these changes
Mar 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially bike-shedding, but I find integration style template-helper tests to be more useful in day-to-day use. This commit only changes default behavior to integration.
Would love to have a discussion about the relative pros and cons of the proposed change.
Cheers!