Simplify action event handler

[GavinJoyce]

As @rwjblue notes, the pre-glimmer 2 implementation had a single data-ember-action="someid" and multiple actions would be registered on that id.

Glimmer 2 has a unique action id per action registration so we no longer need to store the registered actions in an array.

TODO:

• check if we're breaking any addons (just one it seems: ember-native-dom-event-dispatcher)

[rwjblue]

In the pre-glimmer2 implementation it was an array because we only tagged the element with data-ember-action="someid" and that element could have multiple actions:

<button {{action 'foo' on="click"}} {{action 'bar' on="doubleClick"}}></button>

In the glimmer 2 implementation, we have maintained it as an array but it can only ever have one entry.

Some references:

• ember.js/packages/ember-glimmer/lib/modifiers/action.js

  Line 205 in c998c34

  let actionId = uuid();

• ember.js/packages/ember-glimmer/lib/modifiers/action.js

  Lines 43 to 47 in c998c34

  	if (!actions) {
  	actions = ActionManager.registeredActions[actionId] = [];
  	}
  	actions.push(actionState);

I think that registerAction can be simplified to something like:

  registerAction(actionState) {
    let { actionId } = actionState;

    ActionManager.registeredActions[actionId] = actionState;

    return actionId;
  },

[GavinJoyce]

Thanks for the context, I'll update registerAction to remove the arrays and simplify the action handler

[rwjblue]

Since we only care about the attribute starting with the given string, I think you could do:

if (attrName.lastIndexOf('data-ember-action-', 0) !== -1) {

}

[rwjblue]

I don't think we need to cache the length here (we are not mutating AFAICT).

[rwjblue]

ready for a rebase also

[GavinJoyce]

@rwjblue thanks for the feedback, this is 🍏 now.

It appears that only one addon uses ActionManager.registeredActions:

• ember-native-dom-event-dispatcher

[GavinJoyce]

is it ok to remove the if(action && guard here? Do we care about supporting non existent actions?

[rwjblue]

I think this is probably fine. I can't see how we would end up here with an action that is falsey without having already screwed something majorly up elsewhere.

[rwjblue]

I think this is probably fine. I can't see how we would end up here with an action that is falsey without having already screwed something majorly up elsewhere.