[BUGFIX release] Make ember-template-compiler handle {{input}} helpers with sub-expression "type" #14762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaswilli
force-pushed
the
input-type-sexpr
branch
3 times, most recently
from
1cdf28f
to
77202b2
Compare
- Allow {{input}} with a SubExpression type
(e.g., {{input type=(if true 'password' 'text')}})
to be compiled.
rwjblue
force-pushed
the
input-type-sexpr
branch
from
77202b2
to
771cbec
Compare
|
Sorry for the long delay here @jaswilli, I tweaked things around a small amount and added another test. This should land in 2.11.0 (sorry about missing 2.10 😿 ). |
rwjblue
approved these changes
Jan 23, 2017
|
No worries, thanks for the review and fixup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be compiled.
Started failing in 2.10.
jsbin repro: http://jsbin.com/kedozaf/edit?html,js,output