[BUGFIX lts-2-8] Allow canceling items queued by run.schedule.
#14550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the scheduling related `Ember.run.*` methods return the
backburner timer cancelation token with the exception of
`Ember.run.schedule`. (this includes `run.next`, `run.later`,
`run.debounce`, `run.throttle`, and `run.scheduleOnce`).
This seems like a fairly glaring mistake (and makes it impossible to
avoid `if (this.isDestroying) { return; }` guards when using things like
`run.schedule('afterRender'`), so I have marked it as `BUGFIX lts-2-8`.
If others disagree with the severity here, I can change to a simple
`[BUGFIX beta]`.
|
|
|
if we are encouraging people to cancel, we may want improve how we cancel BackburnerJS/backburner.js#177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the scheduling related
Ember.run.*methods return the backburner timer cancelation token with the exception ofEmber.run.schedule. (this includesrun.next,run.later,run.debounce,run.throttle, andrun.scheduleOnce).This seems like a fairly glaring mistake (and makes it impossible to avoid
if (this.isDestroying) { return; }guards when using things likerun.schedule('afterRender'), so I have marked it asBUGFIX lts-2-8. If others disagree with the severity here, I can change to a simple[BUGFIX beta].