[BUGFIX beta] Bump Glimmer #14520
Merged
[BUGFIX beta] Bump Glimmer #14520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where `OutletComponentReference` inadvertently relied on broken behavior: it returned `null`, assuming that that would cause the reference to be rebuilt. But glimmerjs/glimmer-vm#337 fixed the underlying bug, causing the reference to be properly cached. As a result, we need to remember that we rendered a `null` component, so that swapping back to the original component replaces the empty component with the rendered component.
This pulls in two glimmer-engine bugfixes:
- local variables (block params) should always win over helpers
- stateful/class-based helpers used in `{{#if (my-helper ...)}}` and
other block arguments position are destroyed when the block syntax
switches from default to inverse (and vice versa)
Fixes emberjs#14351, emberjs#14413
tilde-engineering
force-pushed
the
bump-glimmer
branch
from
7188b4e
to
8c87e50
Compare
This was referenced Oct 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in two glimmer-engine bugfixes:
{{#if (my-helper ...)}}and other block arguments position are destroyed when the block syntax switches from default to inverse (and vice versa)Fixes #14351, #14413