Fix release regressions. #14281
Merged
Fix release regressions. #14281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwjblue looks good |
|
@rwjblue I'm not sure about the |
| @@ -478,7 +478,7 @@ export default Mixin.create({ | |||
| { id: 'ember-views.dispatching-modify-property', until: '3.0.0' } | |||
| ); | |||
|
|
|||
| if (!this.scheduledRevalidation || this._dispatching) { | |||
| if ((!this.scheduledRevalidation && !this.isDestroying) || this._dispatching) { | |||
There was a problem hiding this comment.
this boolean doesn't seem correct, why would we schedule if isDestroying but we are this._dispatching? seems like isDestroying should just exit early altogether.
rwjblue
force-pushed
the
fix-release-regressions
branch
from
d7b9295
to
67300d6
Compare
|
Good point, updated. |
rwjblue
force-pushed
the
fix-release-regressions
branch
from
67300d6
to
d62be7a
Compare
added 2 commits
September 13, 2016 14:21
Fixes regression related to `willDestroyElement` causing changes to subscribed streams. When that happened, the system would trigger `scheduleRevalidate` on the view (even though it was being destroyed). By the time that the async rerender occurs the queue of things to cleanup in `_destroyingSubtreeForView` has been reset to `null` causing the error reported. This fix simply avoids queueing up rerenders when the component is being destroyed.
Setting `parentView` to `null` is technically better, but unfortunately we have not had this reset in place for a while and folks have dependent keys that include `parentView`. Setting without `Ember.set` triggers the mandatory setter assertion. This removes the clearing of `parentView` (for now) so that we can properly message it being unobservable in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14266.
Fixes #14273.
Note This targets
releasedirectly (as HTMLBars is no longer part of master/beta branches).