Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Ensure injections happen in engine instances. #14140

Merged
merged 2 commits into from
Aug 28, 2016
Merged

[BUGFIX beta] Ensure injections happen in engine instances. #14140

merged 2 commits into from
Aug 28, 2016

Commits on Aug 27, 2016

  1. [BUGFIX beta] Ensure injections happen in engine instances. 

    Prior to this `_environment` could not be relied upon in routes or
views (which is used when `shouldRender: false` is used with `visit`).

The refactor uses the environment to determine what injections to setup
in the engine-instance, and has the `application-instance` defer to the
`engine-instance` to avoid duplication.
    Robert Jackson committed Aug 27, 2016
    Configuration menu
    Copy the full SHA
    3de2360 View commit details
    Browse the repository at this point in the history

  2. [GLIMMER] Ensure all components have injections. 

    Prior to this change we were defaulting to `Ember.Component` which does
not receive injections (which meant it was missing the `renderer`).
This worked "ok" in HTMLBars since we created a default global renderer
to handle components/views without a container/owner.

This change ensures that in the template only component case we fall
back to using the default component looked up from the owner. This
ensures that injections are present.
    Robert Jackson committed Aug 27, 2016
    Configuration menu
    Copy the full SHA
    831c8cb View commit details
    Browse the repository at this point in the history