Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Add more info to the Ember.Binding deprecation. #13920

Merged
merged 1 commit into from
Jul 28, 2016

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jul 27, 2016

The deprecation before:

`Ember.Binding` is deprecated. Consider using an `alias` computed property instead.

The deprecation after:

The `twoWayTest` property of `<(subclass of Ember.Component):ember483>`
is an `Ember.Binding` connected to `direction`, but `Ember.Binding` is
deprecated. Consider using an `alias` computed property instead.

Addresses #13912 (comment).

The deprecation before:

```
`Ember.Binding` is deprecated. Consider using an `alias` computed property instead.
```

The deprecation after:

```
The `twoWayTest` property of `<(subclass of Ember.Component):ember483>`
is an `Ember.Binding` connected to `direction`, but `Ember.Binding` is
deprecated. Consider using an `alias` computed property instead.
```
@mike-north
Copy link
Contributor

This is a massive improvement. Thanks @rwjblue!

@mmun
Copy link
Member

mmun commented Jul 28, 2016

@rwjblue Looks great!

@mmun mmun removed their assignment Jul 28, 2016
@rwjblue rwjblue merged commit 0628013 into emberjs:master Jul 28, 2016
@rwjblue rwjblue deleted the add-info-to-binding-deprecation branch July 28, 2016 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants