Remove Ember.ContainerView #13195
Merged
Remove Ember.ContainerView #13195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroicEric
changed the title
HeroicEric
force-pushed
the
remove-container-view
branch
from
a97dacc
to
063ed7f
Compare
| @@ -123,57 +120,6 @@ QUnit.test('should cleanup bound properties on rerender', function() { | |||
| equal(view.$().text(), 'wycats', 'rendered binding'); | |||
| }); | |||
|
|
|||
| QUnit.test('should update bound values after view\'s parent is removed and then re-appended', function() { | |||
There was a problem hiding this comment.
Should this really be removed or updated to work without using Ember.ContainerView?
|
@rwjblue not sure why the tests are failing on CI but they're all passing locally now. I'll look into why CI is failing. |
|
Hmm seems like they're failing with optional features enabled. Looking into it... |
HeroicEric
force-pushed
the
remove-container-view
branch
from
063ed7f
to
44e418a
Compare
HeroicEric
force-pushed
the
remove-container-view
branch
from
44e418a
to
2e99a02
Compare
HeroicEric
changed the title
|
@rwjblue Going to be stuck in this airport for another few hours. Anything else to work on here? |
|
Nope, looks good to me! |
This was referenced Mar 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued work for #13188
Not sure if there's a way to add this to the other PR instead of creating a new one.