[BUGFIX release-1-13] Remove jQuery version assertion. #12793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
remove-jquery-assertion
branch
from
1bb64fe
to
a9ac424
Compare
|
Looks good to me. Now that ember-cli is the way to go, I think we can more safely rely that people won't be using a version of jQuery that's incompatible. Only other thing we might want to consider is leaving the assertion but for the next major (3.x) just in case something major changes. |
|
should we warn? (i don't really care actually, just due diligence stuff) |
|
meh, lets just remove it. |
stefanpenner
added a commit
that referenced
this pull request
Jan 9, 2016
[BUGFIX release-1-13] Remove jQuery version assertion.
stefanpenner
referenced
this pull request
Jan 9, 2016
This was referenced Jan 9, 2016
omghax
added a commit
to IvyApp/ivy-videojs
that referenced
this pull request
Jan 10, 2016
Currently, Ember has assertions around the version of jQuery being used, which fail with the newly-released jQuery 1.12. There is a fix in the works, but it hasn't been released yet: emberjs/ember.js#12793 For now I've just changed the jQuery dependency from "^1.11.3" to "~1.11.3.", which will target the latest 1.11.x release, but will not use 1.12.
simonihmig
added a commit
to ember-bootstrap/ember-bootstrap
that referenced
this pull request
Jan 11, 2016
heathharrelson
added a commit
to OCTRI/ember-i18next
that referenced
this pull request
Jan 13, 2016
Pin the jQuery dependency to work around Ember issue: emberjs/ember.js#12793
chbonser
pushed a commit
to khorus/ember-accordion
that referenced
this pull request
Feb 22, 2016
lorcan
added a commit
to lorcan/ember-undo-stack
that referenced
this pull request
Apr 25, 2016
Avoids ember-cli/ember-cli#5316 - there's more details [here](ember-cli/ember-cli#5316) and a good description [here](http://benlimmer.com/2016/01/08/ember-jquery-dependancies/): > Just recently, jQuery 1.12.x was released to bower, and Ember-CLI’s default blueprint allowed upgrading to this version. Unfortunately, all current versions of Ember have a hardcoded check that will make you have a bad time. It was fixed in ember by emberjs/ember.js#12793.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.