[BUGFIX Beta] unwatch should not create a new meta #12492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanpenner
commented
Oct 16, 2015
stefanpenner
commented
- m.writeWatching(keyName, count - 1); does require meta, ensure by then we have meta + add covering test...
stefanpenner
force-pushed
the
unwatch-no-meta
branch
from
9237910
to
265d006
Compare
| @@ -102,13 +104,19 @@ export function unwatchKey(obj, keyName, meta) { | |||
| enumerable: true, | |||
| value: val | |||
| }); | |||
| m.deleteFromValues(keyName); | |||
|
|
|||
| var m = peekMeta(obj); | |||
There was a problem hiding this comment.
This definitely seems correct, but shadowing the outer 'm' feels odd to me. Can we use either the variable declared above (just inside the main unwatchKey function) or pick a different variable name than 'm'?
There was a problem hiding this comment.
meant to write let, 1 sec
stefanpenner
force-pushed
the
unwatch-no-meta
branch
from
265d006
to
1c6dcae
Compare
stefanpenner
force-pushed
the
unwatch-no-meta
branch
from
1c6dcae
to
4adca65
Compare
stefanpenner
changed the title
|
unwatch is not supposed to be ever called on something that wasn't watched, can you elaborate on the root cause? |
nope
I'll change it to an assert, and write a test on the inner get always getting its meta on-demand. |
|
superseded by #12491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.