[BUGFIX beta] Remove double loop over attrs to create a component. #12297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would loop over `attrs` and create additional objects for each entry then subsequently merge that "snapshot" back into a target object TWICE for initial render. This updates to loop once over the attrs and do all the work needed in that one pass. It also avoids allocating two temporary objects and the extra `Object.assign` to merge them back into the target.
rwjblue
added a commit
that referenced
this pull request
Sep 5, 2015
[BUGFIX beta] Remove double loop over attrs to create a component.
|
Awesome! ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would loop over
attrsand create additional objects for each entry then subsequently merge that "snapshot" back into a target object TWICE for initial render.This updates to loop once over the attrs and do all the work needed in that one pass. It also avoids allocating two temporary objects and the extra
Object.assignto merge them back into the target.This doesn't have a giant impact on ef4/initial-render-perf (around 6%), but less work is less work and we will take any improvements we can get!