Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release-1-13] Ensure concat streams unsubscribe properly. #12256

Merged
merged 1 commit into from
Sep 1, 2015
Merged

[BUGFIX release-1-13] Ensure concat streams unsubscribe properly. #12256

merged 1 commit into from
Sep 1, 2015

Commits on Sep 1, 2015

  1. [BUGFIX release-1-13] Ensure concat streams unsubscribe properly. 

    The stream returned by `concat` should subscribe to any input
streams so that the "concat stream" is marked as dirty if any of
the input streams are dirtied. This is/was working properly.

Unfortunately, when `subscribe`ing directly as done in 1.13.0, the
subscriptions are never cleared if the "concat stream" is deactivated.
This means, that listeners build up over time and leak the "concat
streams" and the `KeyStream`'s / `ProxyStream`'s that are in use.

Using `stream.addDependency` instead of manually `subscribe`ing allows
the returned "concat stream" to properly remove subscribers when it is
deactivated.
    @rwjblue
    rwjblue committed Sep 1, 2015
    Configuration menu
    Copy the full SHA
    dc4fbd9 View commit details
    Browse the repository at this point in the history