[BUGFIX beta] Make link-to a real component.

[nathanhammond]

Alright, I commit to bringing this home. To-do list from #11962 plus one more:

• Use the new arbitrary-length positional params feature.
• Expose hasBlock on components, privately.
• Use a nested helper to avoid exposing escaped.
• Performance review.
• Test

[rwjblue]

This should be provided as an option in createOptions (so that it is available at init and doesn't change the shape of the object after initialization).

[rwjblue]

We chatted a little bit about this in slack this evening, I think we have a path forward to allowing simple extending of Ember.LinkComponent without exposing hasBlock to the JS-world carte-blanche (via a symbol).

[nathanhammond]

Is this kosher? This is only used for an error message inside an Ember.Deprecate call.

[rwjblue]

Ya, seems fine. Can you also underscore (so hash._view)?

[nathanhammond]

Is our build story clever enough to drop an import if it's only used inside of a runInDebug? We could move this to a symbol and stop squatting on properties.

[rwjblue]

I believe the import would still exist, but I think that is likely fine. Using a symbol here seems good (and helps prevent folks that we are going to start encouraging to use Ember.LinkComponent.extend from relying on the private internals...).

[rwjblue]

This doesn't seem like a compat type thing to me, maybe we can move it to packages/ember-views/lib/system/ instead?

[nathanhammond]

I went with [BUGFIX beta] as this changes nothing and closes #11962.

[rwjblue]

These can be export let HAS_BLOCK... (instead of separate declaration and export statements).

[rwjblue]

I went with [BUGFIX beta]

👍

[rwjblue]

Can you also add [BUGFIX beta] as a commit prefix (I see that you updated the PR title, but not the commit itself)?

[rwjblue]

[mmun]

Good work. Hopefully with @ef4's strategy we can drop the HAS_BLOCK symbol entirely.

[nathanhammond]

Once we have "splat" attrs I think we can adopt @ef4's approach: master...ef4:link-to-cleanup

(/at this point I know it pretty well and might just pick up where he left off.)

[mmun]

I think you can just copy the attrs onto the <a> tag in didRender? Splat would be better tho. :)