Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Fix cacheValuePrefix Error #12037

Merged
merged 1 commit into from
Aug 10, 2015

Conversation

jmurphyau
Copy link
Contributor

Fixed an issue where cacheValuePrefix would incorrectly check "valA in valB" where valB would be null

Fixes #11857

@rwjblue
Copy link
Member

rwjblue commented Aug 10, 2015

Looks good, can you prefix the commit and PR description with [BUGFIX release]?

@mike-north
Copy link
Contributor

awesome

Fixed an issue where cacheValuePrefix would incorrectly check "valA in valB" where valB would be null

Resolves Issue emberjs#11857
@jmurphyau
Copy link
Contributor Author

Didn't notice the failing tests.. Fixing that now

@rwjblue rwjblue changed the title Fix cacheValuePrefix Error [BUGFIX release] Fix cacheValuePrefix Error Aug 10, 2015
rwjblue added a commit that referenced this pull request Aug 10, 2015
[BUGFIX release] Fix cacheValuePrefix Error
@rwjblue rwjblue merged commit 92b8d93 into emberjs:master Aug 10, 2015
@rwjblue
Copy link
Member

rwjblue commented Aug 10, 2015

Thank you!

@novtor
Copy link

novtor commented Sep 30, 2015

Not sure if it is related but starting from 1.13.8 I experience some problems with query parameters. I have following scenario:
parentRoute, childRoute1, childRoute2
parentRoute has queryParams, children do not. When transitionning between children routes, the parentRoute looses its queryParams. The workaround I found (it was a greate chance) is to transition with parentRoute queryParams all set to null -(((. Not sure to understand the logic.
So the working scenrio is:
from childRoute1:

this.transitionTo('childRoute2', {queryParams: {
  parentRouteQP1: null,
  parentRouteQP2: null,
  ....
}});

But before, just

this.transitionTo('childRoute2')

used to work.
Could you investigate on it please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Segments / Query Params / Loading State Produces error with cacheValuePrefix
4 participants