Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy helpers #11965

Merged
merged 3 commits into from
Aug 5, 2015
Merged

Remove legacy helpers #11965

merged 3 commits into from
Aug 5, 2015

Conversation

mixonic
Copy link
Sponsor Member

@mixonic mixonic commented Aug 3, 2015

Replaces #11858

Remove many legacy helper APIs, as well as Handlebars compile usage.

TODO:

  • Deprecate block usage of unbound in 1.13
  • Deprecate multiple arguments being passed to unbound in 1.13

@mmun
Copy link
Member

mmun commented Aug 3, 2015

ooooh, so many removals!

@rwjblue
Copy link
Member

rwjblue commented Aug 3, 2015

semantics for unbound are not the same with new helpers as with old ones. Causing test failures.

Yes, I noticed this as well. I'm perfectly fine with saying that it isn't intended to work, and therefore deprecating {{unbound}} + helper usage (which would make {{unbound}} for unbound props only).

rwjblue added a commit that referenced this pull request Aug 5, 2015
@rwjblue rwjblue merged commit 17b7cc7 into emberjs:master Aug 5, 2015
@rwjblue rwjblue deleted the remove-legacy-helpers branch August 5, 2015 19:52
@rwjblue
Copy link
Member

rwjblue commented Aug 5, 2015

Thank you @mixonic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants