[CLEANUP beta] Remove beforeObserver family from the public API #11796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @private | ||
| */ | ||
| FunctionPrototype.observesBefore = function () { | ||
| var watched = []; |
There was a problem hiding this comment.
this appears to have have been deprecated.
There was a problem hiding this comment.
Do you mean, it was not deprecated?
There was a problem hiding this comment.
Sorry, I mean it did no spew a deprecation warning when used. Is there a sibling PR that introduces that deprecation.
There was a problem hiding this comment.
Ya, good catch.
@cibernox - We need to land a deprecation for this in release before removing.
There was a problem hiding this comment.
There isn't. I'll create one. Put this on hold in the meanwhile
|
Needs a rebase now that #11798 is merged. |
* family inclides `Ember.beforeObserver`, `Ember.addBeforeObserver`, `Ember.removeBeforeObserver`, `Ember.beforeObserversFor`, `Ember._suspendBeforeObserver`, `Ember._suspendBeforeObservers` * I noticed that `beforeObserversFor`, `_suspendBeforeObserver` and `_suspendBeforeObserves` were not used at all, not even internally. I've also checked for usages of it in ember-data, liquid-fire and other "official" porjects. Nothing. So those two are removed completely. * For symetry, I've also removed the `Function.prototype.observesBefore` counterpart.
cibernox
force-pushed
the
remove_before_observers
branch
from
3011b73
to
75569a9
Compare
|
Rebased |
stefanpenner
added a commit
that referenced
this pull request
Jul 17, 2015
[CLEANUP beta] Remove beforeObserver family from the public API
|
SortableMixin from ember-legacy-controllers breaks as it uses beforeObserver :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.beforeObserver,Ember.addBeforeObserver,Ember.removeBeforeObserver,Ember.beforeObserversFor,Ember._suspendBeforeObserver,Ember._suspendBeforeObserversbeforeObserversFor,_suspendBeforeObserverand_suspendBeforeObserveswere not used at all, not even internally. I've also checked for
usages of it in ember-data, liquid-fire and other "official" porjects.
Nothing. So those two are removed completely.
Function.prototype.observesBeforecounterpart.