[BUGFIX release] Ensure Route actions can be unit tested. #11664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ember-qunit@0.3.x the normal `router` injection for all Routes looked up from the container was not set, so the guarding `this.router` was enough to force us down the `else` path in `Ember.Route#send`. ember-qunit@0.4.x fixes many bugs with the previous manual container setup, by doing exactly what a "normal" app would do and use its registry/container pair. This is a **huge** improvement, but unfortunately broke the guard that previously existed (since `this.router` was now the `Ember.Router` instance due to the aforementioned injection rule).
stefanpenner
added a commit
that referenced
this pull request
Jul 6, 2015
[BUGFIX release] Ensure Route actions can be unit tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ember-qunit@0.3.x the normal
routerinjection for all Routes looked up from the container was not set, so the guardingthis.routerwas enough to force us down theelsepath inEmber.Route#send.ember-qunit@0.4.x fixes many bugs with the previous manual container setup, by doing exactly what a "normal" app would do and use its registry/container pair. This is a huge improvement, but unfortunately broke the guard that previously existed (since
this.routerwas now theEmber.Routerinstance due to the aforementioned injection rule).Fixes #11663.