[BUGFIX beta] Add deprecation for view helper #11389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change env value RAISE_ON_DEPRECATION to false * change tests for Ember.deprecate that relied on RAISE_ON_DEPRECATION being true refs emberjs#11377
|
The deprecation links to the Deprecation page in the ember guides (PR there: emberjs/website#2195). |
|
@rwjblue we would appreciate a 👍 from you here. |
rwjblue
added a commit
that referenced
this pull request
Jun 9, 2015
[BUGFIX beta] Add deprecation for view helper
This was referenced Aug 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many tests in the test suite that use the view helper (
{{view 'someview'}}). In addition to adding the deprecation for this usage, this PR unsetsRAISE_ON_DEPRECATIONfor the ember codebase. This allows the test suite to continue to pass for now until we have time to rewrite those tests to use components instead.It also changes some tests in
ember-debugthat presumed that RAISE_ON_DEPRECATION would always be true.refs #11377