Enable {{yield to="inverse"}} in components #11084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream PR merged and published as 0.13.17. Could you rebase and update |
|
Working on the rebase, looks like one minor conflict with |
|
This is ready, CI is blocked on saucelabs. |
rwjblue
added a commit
that referenced
this pull request
May 11, 2015
Enable {{yield to="inverse"}} in components
|
Nice, I have always wanted this! |
rlivsey
added a commit
to minutebase/ember-can
that referenced
this pull request
May 11, 2015
Requires latest Canary - emberjs/ember.js#11084
|
Awesome! 😄 |
kat3kasper
pushed a commit
to kat3kasper/ember-paper
that referenced
this pull request
Mar 25, 2016
Inverse component templates can not recieve parameters. This means there is no access to `searchText` in the inverse block. - Removed inverse template rendering. Instead try to render notFoundComponent then default to notFoundMsg - Update documentation app to reflect these changes See: emberjs/ember.js#11084
kat3kasper
pushed a commit
to kat3kasper/ember-paper
that referenced
this pull request
Mar 25, 2016
Inverse component templates can not recieve parameters. This means there is no access to `searchText` in the inverse block. - Removed inverse template rendering. Instead try to render notFoundComponent then default to notFoundMsg - Update documentation app to reflect these changes See: emberjs/ember.js#11084
kat3kasper
pushed a commit
to kat3kasper/ember-paper
that referenced
this pull request
Mar 30, 2016
Inverse component templates can not recieve parameters. This means there is no access to `searchText` in the inverse block. - Removed inverse template rendering. Instead try to render notFoundComponent then default to notFoundMsg - Update documentation app to reflect these changes See: emberjs/ember.js#11084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates public API for yielding to a component's inverse template. Components can receive an inverse template like:
And can yield to it from within their own template like:
As far as I know, Handlebars does not expose a syntax for giving the inverse block parameters, so there's no practical way to use
{{yield something to="inverse"}}. But nothing in this implementation precludes that from eventually working.My immediate use case is to implement a Glimmer-compatible
liquid-ifas a component. This feature will also be useful to people implementing custom each-like components.Depends on tildeio/htmlbars#340