[BUGFIX beta] Make the component helper able to deal with dynamically set falsey values. #10876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works in IE9 and IE11, busted in IE10. I think Selenium failed and Travis just needs to rerun the job. |
|
Restarted |
|
LGTM. Seem like an OK stopgap @krisselden? |
|
Any update here? |
|
@rwjblue @krisselden I'd really like to ship this with 1.12 and we're closing in on that timeline. |
mmun
added a commit
that referenced
this pull request
Apr 24, 2015
[BUGFIX beta] Make the component helper able to deal with dynamically set falsey values.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
{{component}}helper as it stands is vulnerable to a bound value being updated toundefined(or any falsey value) and then throwing an error, as it previously conflated the component name with a component class. This addresses that by decoupling the component name and class and checking each condition individually. The test fails without the patch, and all other tests pass.@lukemelia should review this. Related to #10739, it fixes the symptom, not the problem (though there are related bugs, @samselikoff). Glimmer fixes the problem by walking the tree.