Deprecate Ember.required #10668
Merged
Deprecate Ember.required #10668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwjblue do we want a deprecation link for this? |
rwjblue
added a commit
to rwjblue/ember-autoresize
that referenced
this pull request
Apr 23, 2015
`Ember.required` hasn't really worked properly, and was deprecated in emberjs/ember.js#10668.
avdv
added a commit
to avdv/ember-resource
that referenced
this pull request
May 27, 2015
As of Ember 1.12 a deprecation warning is emitted to the console when
using `Ember.required`:
```
DEPRECATION: Ember.required is deprecated as its behavior is inconsistent and unreliable.
at Object.required (http://genesis.rbthree.exa-online.de/static-assets/vendor.js:23929:22)
at http://genesis.rbthree.exa-online.de/static-assets/vendor.js:79332:17
at http://genesis.rbthree.exa-online.de/static-assets/vendor.js:80572:2
```
So, remove any usage of `Ember.required` since it hasn't really worked properly.
See emberjs/ember.js#10668
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs deprecation link.
I also admit I'm a bit confused about why the CoreObject actually needs
REQUIRED. I tried to get rid of it and everything broke.