Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Fix an issue with bindings inside of a yielded template when the yield helper is nested inside of another view #10489

Merged
merged 1 commit into from
Feb 18, 2015

Conversation

ebryn
Copy link
Member

@ebryn ebryn commented Feb 18, 2015

@mmun @rwjblue

JSBin showing working 1.9 behavior: http://emberjs.jsbin.com/kejicegowi/1/edit
JSBin showing broken 1.10 behavior: http://emberjs.jsbin.com/pugeweloke/1/edit

…ate when the yield helper is nested inside of another view
@ebryn
Copy link
Member Author

ebryn commented Feb 18, 2015

This will likely fix #10402

@ebryn
Copy link
Member Author

ebryn commented Feb 18, 2015

And perhaps #10401 as well

rwjblue added a commit that referenced this pull request Feb 18, 2015
[BUGFIX release] Fix an issue with bindings inside of a yielded template when the yield helper is nested inside of another view
@rwjblue rwjblue merged commit 87195cf into emberjs:master Feb 18, 2015
@rwjblue
Copy link
Member

rwjblue commented Feb 18, 2015

Cherry-picked into beta and release channels.

@ebryn
Copy link
Member Author

ebryn commented Feb 18, 2015

It does not appear this fixes #10401

@workmanw
Copy link

I know it's a long shot ... but is there any work around for this? It's sadly keeping me from upgrading to 1.10.

@mmun
Copy link
Member

mmun commented Feb 27, 2015

You can use the #stable branch. It has been pulled in.

@workmanw
Copy link

OH I didn't even know you guys maintained that. Sounds like it's the last release + any regression fixes?

@rwjblue
Copy link
Member

rwjblue commented Feb 27, 2015

@workmanw - If you are using bower you can add the following for Ember to get the latest build of the release channel (which is the stable branch):

"ember": "components/ember#release",

@rwjblue
Copy link
Member

rwjblue commented Feb 27, 2015

You can also download it from:

http://emberjs.com/builds/#/release

@workmanw
Copy link

Man that's so awesome. Thanks a lot! ❤️

Totally worked. Viva la HTMLBars. 🍹

@mmun
Copy link
Member

mmun commented Feb 27, 2015

Yay ❤️ Please report any other upgrade problems!

@workmanw
Copy link

@mmun Will do! Virtually all of our issues with 1.10 and HTMLBars were around us forgetting to close tags in our templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants