Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to QUnit 1.17.1. #10345

Merged
merged 2 commits into from
Feb 3, 2015
Merged

Update to QUnit 1.17.1. #10345

merged 2 commits into from
Feb 3, 2015

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Feb 3, 2015

  • Remove raises alias (no longer needed with ES3 safe processing).
  • Replace window.test with QUnit.test.

Starting towards QUnit 2.0 compatibility. Read here for more details.

Remove `raises` alias (no longer needed with ES3 safe processing).
@mixonic
Copy link
Sponsor Member

mixonic commented Feb 3, 2015

Tried to review this the files diff crashed my browser.

🎉

@rwjblue
Copy link
Member Author

rwjblue commented Feb 3, 2015

@mixonic - More changes to come for QUnit 2.0 compat, but due to the massive nature of this diff, I would like to land it quickly to prevent rebase hell...

rwjblue added a commit that referenced this pull request Feb 3, 2015
@rwjblue rwjblue merged commit 73d49ff into emberjs:master Feb 3, 2015
@rwjblue rwjblue deleted the update-qunit branch February 3, 2015 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants