Execute initializers in their respective context

[gf3]

Currently initializers are executed in the global context; this small but useful change will execute the initialize function in the context of its object. Below is an example of where something like this would come in handy. In the example sometimes it's useful (especially with testing) to be able to reset app-state or to switch out various app states at different times.

import Ember from 'ember';

export default {
  name: 'app-state',

  state() {
    return Ember.Object.create({
      components:  Ember.Object.create(),
      controllers: Ember.Object.create(),
      routes:      Ember.Object.create(),
      views:       Ember.Object.create()
    });
  },

  initialize(container, app) {
    app.register('state:main', this.state(), { instantiate: false });

    app.inject('component',  'app-state', 'state:main');
    app.inject('controller', 'app-state', 'state:main');
    app.inject('route',      'app-state', 'state:main');
    app.inject('view',       'app-state', 'state:main');
  }
};

[trek]

👍, although we should probably discuss whether this needs to be flagged and/or is a breaking change as written.

[gf3]

@trek Ahh yeah, I wasn't sure about that. Let me know if you think it needs to be behind a flag and I'll update.

[trek]

Off the top of my head I can't think of a sensible reason to rely on global execution, but that doesn't mean it's not a possibly widely used "feature" that we can't break for 2.0. I'll add it to agenda for the next core team meeting.

[gf3]

@trek Splendid, thank you!

[tomdale]

This seems like an improvement to me, but we should definitely get it feature flagged.

[rwjblue]

The arguments are known, why not just specify them (as opposed to calling apply)?

[manoharank]

@rwjblue It may may helpful when adding/changing the arguments of initialize function in future (not sure).

[gf3]

@manoharank @rwjblue Indeed, future-proofing was my intent here.

[rwjblue]

Using apply is slower than just calling the function and if we refactor the arguments then this may need to be updated anyways (along with many other things). tldr; I would prefer to just invoke the function with the params that we know.

[gf3]

@rwjblue We can't simply call the function, we need to use either call or apply. I can update the PR to use call with named arguments if you would prefer?

[rwjblue]

@gf3 - Did you test it as I suggested? Calling a function from an object should set this inside the function to the object that it was called from.

return initializer.initialize(container, application);

Sample JSBin: http://jsbin.com/wefas/1/edit?html,js,output

[gf3]

@trek @tomdale Should I add the feature flag?

[trek]

@gf3 yes please.

[gf3]

@trek @tomdale Updated—should be good to go!

[rwjblue]

We typically like to use the package name as the prefix. Can you update to ember-application-initializer-context?

[rwjblue]

@gf3 - Thanks!