Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish preview types for Ember #20174

Closed
5 tasks done
Tracked by #20162
chriskrycho opened this issue Aug 29, 2022 · 1 comment
Closed
5 tasks done
Tracked by #20162

Publish preview types for Ember #20174

chriskrycho opened this issue Aug 29, 2022 · 1 comment
Labels
TypeScript Work on Ember’s types

Comments

@chriskrycho
Copy link
Contributor

chriskrycho commented Aug 29, 2022

The basic approach here will be:

  • [FEATURE] Introduce preview types #20180: publish ambient types at types/preview, with:
    • an index.d.ts which imports ember and @ember/* module declarations
    • those declarations as declare module { ... } definitions, so that the root import "just works"
  • document how to opt into the preview types: import 'ember-source/preview'; in:
    • a dedicated blog post after the release of 4.7 and 4.8 beta
    • the release post for 4.8 beta (which can link to the dedicated blog post for more details)
  • add type tests infrastructure for supported TS versions #20185

With that foundation in place, we'll be able to iteratively work on publishing types generated from source (instead of ambient definitions) and once they're stable, flip over to publishing in types/stable and using the typesVersions hack (until we can dependably use an exports map) to define that as stable types.

@chriskrycho chriskrycho changed the title , including: Publish types Aug 29, 2022
@chriskrycho chriskrycho changed the title Publish types Publish types for Ember Aug 29, 2022
@chriskrycho chriskrycho added the TypeScript Work on Ember’s types label Aug 29, 2022
@chriskrycho
Copy link
Contributor Author

We've done the things! More to do, but progress! 🚀

@chriskrycho chriskrycho changed the title Publish types for Ember Publish preview types for Ember Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeScript Work on Ember’s types
Projects
None yet
Development

No branches or pull requests

1 participant