Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ember-application-visit feature guards #13088

Closed
chancancode opened this issue Mar 12, 2016 · 3 comments
Closed

Remove ember-application-visit feature guards #13088

chancancode opened this issue Mar 12, 2016 · 3 comments
Labels
Cleanup Good for New Contributors Help Wanted

Comments

@chancancode
Copy link
Member

The feature has already been enabled on the release channel a while ago, so we should...

  1. Remove it from FEATURES.md
  2. Remove it from features.json
  3. Remove all the isEnabled('ember-application-visit') guards (and fallback code) in the codebase
@cibernox cibernox mentioned this issue Mar 12, 2016
Closed
@shashwat91 shashwat91 mentioned this issue Mar 13, 2016
Merged
@shashwat91
Copy link
Contributor

Created a PR #13100 for this issue.

@josemarluedke
Copy link
Sponsor Contributor

I think this can be closed as #13100 is merged.

@chancancode
Copy link
Member Author

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup Good for New Contributors Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chancancode @josemarluedke @shashwat91