Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixin shape problems #12606

Closed
krisselden opened this issue Nov 14, 2015 · 0 comments
Closed

Mixin shape problems #12606

krisselden opened this issue Nov 14, 2015 · 0 comments
Assignees
@krisselden
Labels
Performance

Comments

@krisselden
Copy link
Contributor

Add GUID_KEY = null to Mixin constructor and toString
Remove private NativeArray.activate and TextSupport.KEY_EVENTS
@krisselden krisselden self-assigned this Nov 14, 2015
krisselden added a commit that referenced this issue Nov 15, 2015
@krisselden
WIP to fix #12606
37b3a6d 
Needs review, needs to import NAME_KEY, we really should be using the same symbol() method for everything.  The classToString stuff is making me emo, can we just get rid of it? In the module world, no one puts mixins into the container or onto their App 'namespace' so it just ends up being an '(unknown mixin)'
@krisselden krisselden mentioned this issue Nov 15, 2015
Merged
krisselden added a commit that referenced this issue Nov 16, 2015
@krisselden
Fix #12606
9a6da96
krisselden added a commit that referenced this issue Nov 16, 2015
@krisselden
Fix #12606
4b2d6d4
homu added a commit that referenced this issue Nov 16, 2015
@homu
Auto merge of #12612 - emberjs:fix-mixin-shape, r=krisselden
72a2b89 
[PERF] Fix Mixin shape issues

Fix #12606

Make Mixin monomorphic and use debugSeal in development builds to flag issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krisselden krisselden

Labels
Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krisselden