Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addons] make _registerHelper public #11311

Closed
bcardarella opened this issue May 31, 2015 · 6 comments
Closed

[Addons] make _registerHelper public #11311

bcardarella opened this issue May 31, 2015 · 6 comments

Comments

@bcardarella
Copy link
Contributor

I am using _registerHelper in several addons to get around the hyphenation requirement. can we get we get this method to be made public?

@mmun
Copy link
Member

mmun commented May 31, 2015

@bcardarella We're not going to expose that method because it exposes streams. @mixonic and @rwjblue have an RFC detailing the path to hyphenless helpers: emberjs/rfcs#58.

TL;DR: Helpers should not require a hyphen. Hyphens are only for custom elements. But we need to implement a strategy that avoids tons of unnecessary container lookups (which is what the RFC details) before we can allow it.

@bcardarella
Copy link
Contributor Author

@mmun what are the odds that this RFC is going to land for 2.0? Without a clear path on how my addons will work in 2.0 I'm pretty much stuck. Its nice that there is an RFC to add a better API for this eventually but in the meantime I don't think I can update my addons and test them against 1.13 in any way

@rwjblue
Copy link
Member

rwjblue commented May 31, 2015

@bcardarella we are planning on to landing both emberjs/rfcs#53 and emberjs/rfcs#58 in 1.13.0.

@bcardarella
Copy link
Contributor Author

this is good news, thank you

@samtsai
Copy link

samtsai commented Jan 25, 2016

@bcardarella looks like we can try confirming that your addons work with the helper updates that landed in 1.13 and close this issue out if all good.

@mmun mmun closed this as completed Jan 25, 2016
@mmun
Copy link
Member

mmun commented Jan 25, 2016

Thanks @samtsai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants