Using Modal Dialogs - undefined error in canary

[iamjstates]

In canary the below code does not work and yields the following error:

Uncaught TypeError: Cannot read property 'routeName' of undefined

It points to *return this.render(modalName, *

App.ApplicationRoute = Ember.Route.extend({
  actions: {
    openModal: function(modalName) {
      return this.render(modalName, {
        into: 'application',
        outlet: 'modal'
      });
    }
  }
});

[ilkkao]

I noticed the same problem in my Selenium tests this morning. I didn't have time to debug so I went back to beta1 which fixed the problem.

[iamjstates]

Thanks @ilkkao - I guess the team is aware of the problem?

[stefanpenner]

@ef4 this may be related to the recent outlet fixes/refactoring

[ilkkao]

I just bisected the problem to #10372

In my case I use modals exactly as instructed here: http://emberjs.com/guides/cookbook/user_interface_and_interaction/using_modal_dialogs/

Maybe the example from there can be upgraded to use canary version to demonstrate the problem?

[ilkkao]

Wasn't too hard. Demo here: http://emberjs.jsbin.com/dupufilora/1/edit?html,js,output

Click 'change name' to see the error.

[ilkkao]

This is a duplicate of #10427

[rwjblue]

The error is being thrown from: ember-routing/lib/system/route.js. Basically, when rendering into an outlet in the application route, there are is no parent route and we are calling routeName on undefined.

@ef4 - Should we just guard against this (parentRoute(route) being undefined), or is there a better solution?

[ef4]

Just adding a guard should be sufficient. I can work on it tonight if nobody gets to it first.

We should also make sure we add a regression test for this case.

[iamjstates]

The fix works for opening modals, but this:

closeModal: function() {
    return this.disconnectOutlet({
      outlet: 'modal',
      parentView: 'application'
    });
  }

now yields: Uncaught TypeError: Cannot read property 'routeName' of undefined

[ef4]

@iamjstates I just submitted another PR that takes care of disconnection too.

Thanks for being a beta tester. I've added all these scenarios to the integration tests so we never break these behaviors on people again.

[iamjstates]

@ef4 - No worries, glad to help out in anyway.