Skip to content

Commit

Permalink
[BUGFIX beta] Ensures Ember.A is a constructor
Browse files Browse the repository at this point in the history
The recent change to transpilation has made `new A()` break, because
A is an arrow function and arrow functions cannot be constructors. This
is a pretty common pattern in Ember apps and likely constitutes a
breaking change, so this PR fixes it by changing the arrow function to
a normal function, and deprecates this behavior.
  • Loading branch information
pzuraq committed Nov 29, 2018
1 parent 7666b70 commit b6cd574
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 2 deletions.
29 changes: 27 additions & 2 deletions packages/@ember/-internals/runtime/lib/mixins/array.js
Original file line number Diff line number Diff line change
Expand Up @@ -1641,9 +1641,34 @@ let A;

if (ENV.EXTEND_PROTOTYPES.Array) {
NativeArray.apply(Array.prototype);
A = arr => arr || [];

A = function(arr) {
if (this instanceof A) {
deprecate(
'`new A()` has been deprecated, please update to calling A as a function: `A()`',
false,
{
id: 'array.new-array-wrapper',
until: '3.9.0',
url: 'https://emberjs.com/deprecations/v3.x#toc_new-array-wrapper',
}
);
}
return arr || [];
};
} else {
A = arr => {
A = function(arr) {
if (this instanceof A) {
deprecate(
'`new A()` has been deprecated, please update to calling A as a function: `A()`',
false,
{
id: 'array.new-array-wrapper',
until: '3.9.0',
url: 'https://emberjs.com/deprecations/v3.x#toc_new-array-wrapper',
}
);
}
if (!arr) {
arr = [];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,15 @@ moduleFor(
assert.ok(EmberArray.detect(A()), 'returned an ember array');
assert.ok(EmberArray.detect(A([1, 2])), 'returned an ember array');
}

['@test new Ember.A'](assert) {
expectDeprecation(() => {
assert.deepEqual(new A([1, 2]), [1, 2], 'array values were not be modified');
assert.deepEqual(new A(), [], 'returned an array with no arguments');
assert.deepEqual(new A(null), [], 'returned an array with a null argument');
assert.ok(EmberArray.detect(new A()), 'returned an ember array');
assert.ok(EmberArray.detect(new A([1, 2])), 'returned an ember array');
});
}
}
);

0 comments on commit b6cd574

Please sign in to comment.