Keep browserstack key in plaintext

It turns out this was intentional. The key has no privileged access to anything in our case, and it needs to be in plaintext if we want to run browserstack against PRs.
emberjs · Oct 3, 2020 · 5becf88 · 5becf88
1 parent b3d075f
commit 5becf88
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -88,7 +88,9 @@ jobs:
       - name: test:browserstack
         env:
           BROWSERSTACK_USERNAME: emberjscoreteam1
-          BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
+          # This is in plaintext on purpose. It has no privileged access to anything (this is a free
+          # account) and it allows us to run browserstack tests against PRs.
+          BROWSERSTACK_ACCESS_KEY: o5LNEdygq1SP4L9kst4s
         run: yarn test:browserstack
 
   production-test: