enable templates read a property from a function

emberjs · Aug 18, 2017 · 326dc3d · 326dc3d
1 parent 8f68cf0
commit 326dc3d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 14 deletions.
diff --git a/packages/ember-glimmer/tests/integration/content-test.js b/packages/ember-glimmer/tests/integration/content-test.js
@@ -495,17 +495,17 @@ class DynamicContentTest extends RenderingTest {
 
     this.assertStableRerender();
 
-    // this.runTask(() => set(func, 'aProp', 'still a property on a function'));
-    // this.assertContent('still a property on a function');
-    // this.assertInvariants();
+    this.runTask(() => set(func, 'aProp', 'still a property on a function'));
+    this.assertContent('still a property on a function');
+    this.assertInvariants();
 
-    // func = () => {};
-    // func.aProp = 'a prop on a new function';
+    func = () => {};
+    func.aProp = 'a prop on a new function';
 
-    // this.runTask(() => set(this.context, 'func', func));
+    this.runTask(() => set(this.context, 'func', func));
 
-    // this.assertContent('a prop on a new function');
-    // this.assertInvariants();
+    this.assertContent('a prop on a new function');
+    this.assertInvariants();
   }
 }
 

diff --git a/packages/ember-metal/lib/property_set.js b/packages/ember-metal/lib/property_set.js
@@ -67,7 +67,6 @@ export function set(obj, keyName, value, tolerant) {
 
     propertyDidChange(obj, keyName, meta);
   }
-
   return value;
 }
 

diff --git a/packages/ember-metal/lib/tags.js b/packages/ember-metal/lib/tags.js
@@ -13,7 +13,7 @@ function makeTag() {
 }
 
 export function tagForProperty(object, propertyKey, _meta) {
-  if (typeof object !== 'object' || object === null) { return CONSTANT_TAG; }
+  if ((typeof object !== 'object' && typeof object !== 'function') || object === null) { return CONSTANT_TAG; }
 
   let meta = _meta || metaFor(object);
   if (meta.isProxy()) {

diff --git a/packages/ember-metal/lib/watch_key.js b/packages/ember-metal/lib/watch_key.js
@@ -14,7 +14,7 @@ import {
 let handleMandatorySetter;
 
 export function watchKey(obj, keyName, meta) {
-  if (typeof obj !== 'object' || obj === null) { return; }
+  if (typeof obj !== 'object' && typeof obj !== 'function' || obj === null) { return; }
 
   let m = meta || metaFor(obj);
   let count = m.peekWatching(keyName) || 0;
@@ -81,9 +81,8 @@ if (MANDATORY_SETTER) {
 }
 
 export function unwatchKey(obj, keyName, _meta) {
-  if (typeof obj !== 'object' || obj === null) {
-    return;
-  }
+  if (typeof obj !== 'object' && typeof obj !== 'function' || obj === null) { return; }
+
   let meta = _meta || peekMeta(obj);
 
   // do nothing of this object has already been destroyed