Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add jQuery-based event dispatcher as part of RFC386 #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Add jQuery-based event dispatcher as part of RFC386 #31

wants to merge 1 commit into from

Conversation

simonihmig
Copy link
Contributor

@simonihmig simonihmig commented Jan 12, 2019 •
edited
Loading

Largely inspired by ember-native-dom-event-dispatcher.

@simonihmig simonihmig changed the title Add jQuery-based event dispatcher as part of RFC386 [WIP] Add jQuery-based event dispatcher as part of RFC386 Jan 12, 2019
@simonihmig simonihmig mentioned this pull request Jan 12, 2019
Closed
16 tasks
@simonihmig simonihmig changed the title [WIP] Add jQuery-based event dispatcher as part of RFC386 Add jQuery-based event dispatcher as part of RFC386 Feb 7, 2019
@simonihmig
Copy link
Contributor Author

@rwjblue rebased this, and should be ready for review. Although this is not really that urgent, as it will only come into effect once Ember 4.0 (canary) is released.

I tested this locally by changing this line (https://github.com/emberjs/ember-jquery/pull/31/files#diff-168726dbe96b3ce427e7fedce31bb0bcR4) to some earlier version, so that the EventDispatcher is actually used, and tests were passing. But the real tests will only be possible once we have an Ember version w/o jQuery...

@kategengler kategengler mentioned this pull request Feb 12, 2019
Closed
24 tasks
@simonihmig simonihmig mentioned this pull request Apr 12, 2019
Closed
3 tasks
@simonihmig simonihmig changed the title Add jQuery-based event dispatcher as part of RFC386 WIP: Add jQuery-based event dispatcher as part of RFC386 Oct 2, 2019
@simonihmig
Copy link
Contributor Author

Reminder to myself: #148 introduced some changed semantics, that the jQuery related Ember APIs (including EventDispatcher tackled in this PR) are only "backported" when the jQuery integration flag is explicitly set to true. This PR needs to accommodate this, i.e. not override the core EventDispatcher when integration is not enabled!

@rwjblue rwjblue mentioned this pull request Oct 14, 2019
Open
@simonihmig simonihmig mentioned this pull request Oct 3, 2020
Closed
@locks locks self-assigned this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees

@locks locks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonihmig @locks