[FEAT] Decorator and Class Field Support #274

pzuraq · 2019-03-16T16:25:57Z

This PR adds the decorator and class field transforms directly to the
stardard Ember build, so users can rely on ember-cli-babel to provide
them and won't have to manage their own transforms package. It does
not add these transforms if it detects that the plugins have already
been added by something else, and instead warns.

This PR adds the decorator and class field transforms directly to the stardard Ember build, so users can rely on `ember-cli-babel` to provide them and won't have to manage their own transforms package. It does _not_ add these transforms if it detects that the plugins have already been added by something else, and instead warns.

stefanpenner · 2019-03-25T20:40:51Z

index.js

+    ) {
+      this.project.ui.writeWarnLine(`${
+        this._parentName()
+      } has added the decorators and/or class properties plugins to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms. Ember supports the stage 1 decorator spec and transforms, so if you were using stage 2, you'll need to ensure that your decorators are compatible, or convert them to stage 1.`);


I am slightly worried by line-noise cause by this warning, i have some questions:

how often does this fire for a large app (with many nested ember-cli-babel's)?

can it be reduced further, and maybe more meaty details to a readme?

it should likely surface what version of ember-cli-babel now provides this via

where does a user remove the decorators from, their add-on or their app or...

Those are good points. Do you think we should only warn if it's a top level thing? So, apps will warn, and addons will only warn if they are being worked on/developed. I've found this a good way to move the ecosystem forward in the past when things aren't incredibly pressing, and I think this qualifies since the transforms do tend to be limited to a single package.

stefanpenner · 2019-03-25T20:46:30Z

I left a note, re: warning. But otherwise 👍 .

Question, for non-decorator users how much does this slow down the users babel?

pzuraq · 2019-03-25T20:53:19Z

I haven't seen any noticeable changes in build-speed, but I also haven't used the decorator transforms in a large application. Is there a way we can benchmark to find out what the change would be?

stefanpenner · 2019-03-25T21:11:26Z

I haven't seen any noticeable changes in build-speed, but I also haven't used the decorator transforms in a large application. Is there a way we can benchmark to find out what the change would be?

Super low tech, is something like: rm -rf $TMPDIR/$USER && time ember b
Although the above will be relatively low fidelity, we are really just looking for large regressions, as anything minor is outweighed by the value of this pr.

pzuraq · 2019-03-27T15:15:52Z

I benchmarked and shared results with @stefanpenner offline, this does not appear to be a regression performance-wise. I've also updated the warning to only log in the root application/addon, so users won't get large amounts of noise from addons they don't control.

I think this should be good to go!

warning issue addressed

rwjblue · 2019-03-27T15:38:18Z

ember-cli-babel 7.7.0 published 🎉

stefanpenner · 2019-03-27T15:38:42Z

Thanks for the extra diligence

LordCHTsai · 2019-03-28T00:53:23Z

Ran into an issue when reinstalling dependencies within my project. ember-cli@3.7.0 requires ember-cli-babel@^7.6.0 so it installed 7.7.0 because of the ^ symbol. Then I guess because of some of the subdependencies use decorators-legacy, I got the error

Build Error (broccoli-persistent-filter:Babel > [Babel: ember-data]) in ember-data/adapters/errors.js

Cannot use the decorators and decorators-legacy plugin together

disableDecoratorTransforms: true doesn't seem to work to me.

pzuraq · 2019-03-28T03:12:15Z

Hey @LordCHTsai, can you possibly provide a reproduction? It seems strange that the plugin would be included twice, definitely would like to get to the bottom of it.

LordCHTsai · 2019-03-28T17:23:55Z

@pzuraq here's the reproduction
npm install -g ember@3.7.0 (also confirm 3.7.1 also fails, but 3.8.1 works fine)

 >  ember version
ember-cli: 3.7.1
node: 10.15.1
os: darwin x64

> ember new ember-quickstart-ya
> cd ember-quickstart-ya
> npm install
> ember serve
Build Error (broccoli-persistent-filter:Babel > [Babel: ember-data]) in ember-data/-debug/index.js

Cannot use the decorators and decorators-legacy plugin together


Stack Trace and Error Report: /var/folders/v1/4g8cyy3j0hj485fyx7h964h8001336/T/error.dump.f67baab64d5e9d29c0174e55f465b659.log

and here's the log

=================================================================================

ENV Summary:

  TIME: Thu Mar 28 2019 10:18:12 GMT-0700 (Pacific Daylight Time)
  TITLE: ember
  ARGV:
  - /Users/chetsai/.nvm/versions/node/v10.15.1/bin/node
  - /Users/chetsai/.nvm/versions/node/v10.15.1/bin/ember
  - serve
  EXEC_PATH: /Users/chetsai/.nvm/versions/node/v10.15.1/bin/node
  TMPDIR: /var/folders/v1/4g8cyy3j0hj485fyx7h964h8001336/T
  SHELL: /bin/bash
  PATH:
  - /Users/chetsai/.nvm/versions/node/v10.15.1/bin
  - /Users/chetsai/.pyenv/shims
  - /usr/local/bin
  - /usr/local/sbin
  - /usr/bin
  - /bin
  - /usr/sbin
  - /sbin
  - /usr/local/linkedin/bin
  - /export/content/linkedin/bin
  PLATFORM: darwin x64
  FREEMEM: 9791586304
  TOTALMEM: 34359738368
  UPTIME: 603078
  LOADAVG: 7.89990234375,4.79345703125,4.330078125
  CPUS:
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  - Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz - 2900
  ENDIANNESS: LE
  VERSIONS:
  - ares: 1.15.0
  - cldr: 33.1
  - http_parser: 2.8.0
  - icu: 62.1
  - modules: 64
  - napi: 3
  - nghttp2: 1.34.0
  - node: 10.15.1
  - openssl: 1.1.0j
  - tz: 2018e
  - unicode: 11.0
  - uv: 1.23.2
  - v8: 6.8.275.32-node.12
  - zlib: 1.2.11

ERROR Summary:

  - broccoliBuilderErrorStack: Error: Cannot use the decorators and decorators-legacy plugin together
    at validatePlugins (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/parser/lib/index.js:11085:13)
    at getParser (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/parser/lib/index.js:11150:5)
    at parse (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/parser/lib/index.js:11133:12)
    at parser (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/core/lib/transformation/normalize-file.js:170:34)
    at normalizeFile (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/core/lib/transformation/normalize-file.js:138:11)
    at runSync (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/core/lib/transformation/index.js:44:43)
    at transformSync (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/core/lib/transform.js:43:38)
    at Object.transform (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/core/lib/transform.js:22:38)
    at resolve (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/ember-cli-babel/node_modules/broccoli-babel-transpiler/lib/worker.js:11:29)
    at initializePromise (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/ember-cli-babel/node_modules/rsvp/dist/rsvp.js:520:5)
  - code: [undefined]
  - codeFrame: Cannot use the decorators and decorators-legacy plugin together
  - errorMessage: ember-data/-debug/index.js: Cannot use the decorators and decorators-legacy plugin together
        in /var/folders/v1/4g8cyy3j0hj485fyx7h964h8001336/T/broccoli-67954wuxWwsX56Bsd/out-076-funnel
        at broccoli-persistent-filter:Babel > [Babel: ember-data] (Babel: ember-data)
  - errorType: Build Error
  - location:
    - column: [undefined]
    - file: ember-data/-debug/index.js
    - line: [undefined]
    - treeDir: /var/folders/v1/4g8cyy3j0hj485fyx7h964h8001336/T/broccoli-67954wuxWwsX56Bsd/out-076-funnel
  - message: ember-data/-debug/index.js: Cannot use the decorators and decorators-legacy plugin together
        in /var/folders/v1/4g8cyy3j0hj485fyx7h964h8001336/T/broccoli-67954wuxWwsX56Bsd/out-076-funnel
        at broccoli-persistent-filter:Babel > [Babel: ember-data] (Babel: ember-data)
  - name: BuildError
  - nodeAnnotation: Babel: ember-data
  - nodeName: broccoli-persistent-filter:Babel > [Babel: ember-data]
  - originalErrorMessage: Cannot use the decorators and decorators-legacy plugin together
  - stack: Error: Cannot use the decorators and decorators-legacy plugin together
    at validatePlugins (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/parser/lib/index.js:11085:13)
    at getParser (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/parser/lib/index.js:11150:5)
    at parse (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/parser/lib/index.js:11133:12)
    at parser (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/core/lib/transformation/normalize-file.js:170:34)
    at normalizeFile (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/core/lib/transformation/normalize-file.js:138:11)
    at runSync (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/core/lib/transformation/index.js:44:43)
    at transformSync (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/core/lib/transform.js:43:38)
    at Object.transform (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/@babel/core/lib/transform.js:22:38)
    at resolve (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/ember-cli-babel/node_modules/broccoli-babel-transpiler/lib/worker.js:11:29)
    at initializePromise (/Users/chetsai/Work/test-ember-3/ember-quickstart-ya/node_modules/ember-cli-babel/node_modules/rsvp/dist/rsvp.js:520:5)

=================================================================================

LordCHTsai · 2019-03-28T17:41:09Z

Update:
By looking into the log, it seems like it happens when building ember-data, so I tried to bump the ember-data version to 3.8.0 and keep ember-cli version the same 3.7.0, it actually works.

At least it's narrowing down to ember-data. I will keep digging into the reason.

simonihmig · 2019-03-28T17:54:06Z

Just ran into this as well. Created a new app with Ember CLI 3.7 and ran ember s. Downgrading ember-cli-babel to 7.6.0 (using yarn resolutions) also fixed this!

pzuraq · 2019-03-28T20:23:36Z

@rwjblue and I tracked it down this morning: #275

TL;DR: babel-plugin-filter-imports was doing bad things ☹️

buschtoens mentioned this pull request Mar 18, 2019

docs(README): address "decorator support" RFC ember-decorators/ember-decorators#415

Open

Chris Garrett added 2 commits March 19, 2019 17:51

add decorator and class field acceptance tests

5c2b079

add disableDecoratorTransforms

520190f

pzuraq force-pushed the feat/decorator-and-class-field-support branch from 766f277 to 520190f Compare March 20, 2019 16:50

rwjblue approved these changes Mar 23, 2019

View reviewed changes

stefanpenner previously requested changes Mar 25, 2019

View reviewed changes

only warn for root apps/addons

80e42a4

pzuraq force-pushed the feat/decorator-and-class-field-support branch from ec4a47f to 80e42a4 Compare March 27, 2019 15:14

rwjblue added the enhancement label Mar 27, 2019

rwjblue approved these changes Mar 27, 2019

View reviewed changes

rwjblue merged commit 591de2b into emberjs:master Mar 27, 2019

josemarluedke mentioned this pull request Mar 27, 2019

Use ember-cli-babel 7.7.0 for decorators support ember-cli/ember-octane-blueprint#89

Merged

pzuraq deleted the feat/decorator-and-class-field-support branch March 28, 2019 20:23

kategengler mentioned this pull request Apr 11, 2019

RFC #0408 - Tracking for Decorators emberjs/rfc-tracking#7

Closed

15 tasks

kategengler mentioned this pull request Apr 26, 2019

RFC #0440 - Tracking for Decorator Support emberjs/rfc-tracking#41

Closed

5 tasks

rwjblue mentioned this pull request Jun 11, 2019

@babel/plugin-proposal-class-properties issue embroider-build/embroider#214

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEAT] Decorator and Class Field Support #274

[FEAT] Decorator and Class Field Support #274

pzuraq commented Mar 16, 2019 •

edited by rwjblue

Loading

stefanpenner Mar 25, 2019

pzuraq Mar 25, 2019

stefanpenner commented Mar 25, 2019 •

edited

Loading

pzuraq commented Mar 25, 2019

stefanpenner commented Mar 25, 2019

pzuraq commented Mar 27, 2019

rwjblue commented Mar 27, 2019

stefanpenner commented Mar 27, 2019

LordCHTsai commented Mar 28, 2019 •

edited

Loading

pzuraq commented Mar 28, 2019

LordCHTsai commented Mar 28, 2019

LordCHTsai commented Mar 28, 2019

simonihmig commented Mar 28, 2019 •

edited

Loading

pzuraq commented Mar 28, 2019

[FEAT] Decorator and Class Field Support #274

[FEAT] Decorator and Class Field Support #274

Conversation

pzuraq commented Mar 16, 2019 • edited by rwjblue Loading

stefanpenner Mar 25, 2019

Choose a reason for hiding this comment

pzuraq Mar 25, 2019

Choose a reason for hiding this comment

stefanpenner commented Mar 25, 2019 • edited Loading

pzuraq commented Mar 25, 2019

stefanpenner commented Mar 25, 2019

pzuraq commented Mar 27, 2019

rwjblue commented Mar 27, 2019

stefanpenner commented Mar 27, 2019

LordCHTsai commented Mar 28, 2019 • edited Loading

pzuraq commented Mar 28, 2019

LordCHTsai commented Mar 28, 2019

LordCHTsai commented Mar 28, 2019

simonihmig commented Mar 28, 2019 • edited Loading

pzuraq commented Mar 28, 2019

pzuraq commented Mar 16, 2019 •

edited by rwjblue

Loading

stefanpenner commented Mar 25, 2019 •

edited

Loading

LordCHTsai commented Mar 28, 2019 •

edited

Loading

simonihmig commented Mar 28, 2019 •

edited

Loading