[CHORE] Move PromiseBelongsTo, PromiseManyArray and ManyArray to model package #6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
requested changes
Nov 28, 2019
There was a problem hiding this comment.
Noticed a few things, we should pair on this over the break. There's a small bit of weirdness in InternalModel due to CUSTOM_MODEL_CLASS and the Reference API which if we cleanup we can move tons more to the model class without adding complexity or entanglement.
runspired
force-pushed
the
move_promise_proxies_and_manyarray
branch
from
3bbc431
to
8bd36ba
Compare
runspired
approved these changes
Nov 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6166
Also fixes some missing docs