[CHORE tests] simplify setupStore registrations #6353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
the
🌲 Project Trim 🌲
|
cc @HeroicEric This complements #6347 |
snewcomer
reviewed
Aug 21, 2019
| @@ -31,7 +30,6 @@ function initializeStore(registry) { | |||
| registerOptionsForType.call(registry, 'adapter', { singleton: false }); | |||
| registry.register('serializer:-default', JSONSerializer); | |||
| registry.register('serializer:-rest', RESTSerializer); | |||
| registry.register('adapter:-rest', RESTAdapter); | |||
There was a problem hiding this comment.
Out of curiosity - this isn't a "breaking" change, right? (still acclimating)
There was a problem hiding this comment.
Correct. The existence of this adapter was for tests and private. To use it folks would have had to discover it and looked it up via -rest manually. Given the easy of importing RESTAdapter and no evidence of usage I don’t believe we need to treat this as intimate.
runspired
changed the title
igorT
reviewed
Aug 21, 2019
igorT
reviewed
Aug 21, 2019
igorT
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for more incremental migration away from
createStoreandsetupStoreto modern test syntax.Specifically it
cc @pete-the-pete @snewcomer