[INTERNAL]: replace -rest adapter usage in tests #6342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
force-pushed
the
sn/-rest
branch
4 times, most recently
from
74ba19f
to
7abf146
Compare
snewcomer
commented
Aug 18, 2019
| assert.ok(!didInstantiateAppAdapter, 'We did not instantiate the application adapter again'); | ||
| assert.ok(didInstantiateRestAdapter, 'We instantiated the fallback adapter'); | ||
| assert.ok(restAdapter !== appAdapter, `We did not use the application adapter instance`); | ||
| }); | ||
|
|
||
| test('we can specify a fallback adapter by name in place of the application adapter', async function(assert) { |
There was a problem hiding this comment.
near duplicate of another test above
snewcomer
changed the title
runspired
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to eliminate
-restusage as described in #6166.-restfrom usage in tests and instead registerapplicationFollow up:
-restfromcreateStore&&setupStore-defaultfromcreateStore&&setupStoreand instead registerapplication. Don't set this adapter on store in these helpers...
Ref #6166