[FEAT identifiers] Implements RFC #403 #5914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
force-pushed
the
rfc-403/identifiers
branch
3 times, most recently
from
a37bf3e
to
f386769
Compare
* [FEAT identifiers] adds uuid-v4 util * [FEAT identifiers] adds ts-interface for json-api concepts w/ember-data flavor * [FEAT identifier] adds toString to interface for even more debuggability * [FEAT identifier] makes debug members of the interface optional * [FEAT IdentifierCache] implements the cache to spec * record-data-wrapper -> store-wrapper.js (fix name) * fix store usage by relationships without leaking to RecordData
runspired
force-pushed
the
rfc-403/identifiers
branch
from
1390073
to
0bcf4e1
Compare
6 tasks
mike-north
suggested changes
Apr 5, 2019
| @@ -0,0 +1 @@ | |||
| export type Dict<K extends string, V> = { [KK in K]: V }; | |||
There was a problem hiding this comment.
This is not a type-safe interface, since the possibility of missing values isn't accounted for
Suggested change
| export type Dict<K extends string, V> = { [KK in K]: V }; | |
| export type Dict<K extends string, V> = { [KK in K]: V | undefined }; |
|
|
||
| constructor(store, identifierCache) { | ||
| this._identifierCache = identifierCache; | ||
| this._store = store; |
There was a problem hiding this comment.
These two can be converted to parameter properties
constructor(private _store: any, private _identifierCache: IdentifierCache) {}| private _cache = { | ||
| lids: Object.create(null) as IdentifierMap, | ||
| types: Object.create(null) as TypeMap | ||
| }; |
There was a problem hiding this comment.
you may want to favor use of a type annotation over casting
| this._generate = configuredGenerationMethod || defaultGenerationMethod; | ||
| this._update = configuredUpdateMethod || defaultUpdateMethod; | ||
| this._forget = configuredForgetMethod || defaultForgetMethod; | ||
| this._reset = configuredResetMethod || defaultResetMethod; |
There was a problem hiding this comment.
Is there a reason why class field initializers aren't used here?
|
|
||
| function isNonEmptyString(str?: string | null): str is string { | ||
| return typeof str === 'string' && str.length > 0; | ||
| } |
There was a problem hiding this comment.
You can make this a more useful check through using a generic.
function isNonEmptyString<T extends string>(str: T | undefined | null | ''): str is T {
return typeof str === 'string' && str.length > 0;
}This will allow it to work correctly with unioned string literal types
let x = 'bar' as '' | 'foo' | 'bar';
if (isNonEmptyString(x)) {
x // 'foo' | 'bar' (yours would have included '')
} else {
x // '' (yours would have been never)
}| lid: Object.create(null), | ||
| id: Object.create(null), | ||
| _allIdentifiers: [], | ||
| } as KeyOptions; |
There was a problem hiding this comment.
prefer type annotation over casting
|
Replaced by #6247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifiers RFC