From 6f08880274ceeefee8e30218404ae006a777647a Mon Sep 17 00:00:00 2001 From: Amit Yadav Date: Wed, 18 Sep 2024 15:45:15 +0530 Subject: [PATCH] validate --- x/tradeshield/types/message_update_params.go | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/x/tradeshield/types/message_update_params.go b/x/tradeshield/types/message_update_params.go index 97e89ff8..37e0d891 100644 --- a/x/tradeshield/types/message_update_params.go +++ b/x/tradeshield/types/message_update_params.go @@ -43,6 +43,19 @@ func (msg *MsgUpdateParams) ValidateBasic() error { return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "invalid creator address (%s)", err) } - // TODO: Validate params + // Validate params + if msg.Params.LimitProcessOrder <= 0 { + return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "LimitProcessOrder must be greater than 0") + } + if msg.Params.RewardPercentage.IsNegative() { + return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "RewardPercentage must be non-negative") + } + if msg.Params.MarginError.IsNegative() { + return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "MarginError must be non-negative") + } + if msg.Params.MinimumDeposit.IsNegative() { + return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "MinimumDeposit must be non-negative") + } + return nil }