Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Windows phone 10 Edge bug (#193) #294

Closed
wants to merge 2 commits into from

Conversation

MartinHlavna
Copy link

Degradation to <a download> attribute in windows phone 10.

This is submitted as issue #193 . Since MS is not giving any progress on this issue, I have created workaround that sniffs user agent to detect windows phone 10. On these devices is then used "a download" attribute. However this solution is not able to override file name, which will save the the file as blob UUID.

This is also submitted as issue

https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/6594876/

but is has been lately marked as fixed.

@jimmywarting
Copy link
Collaborator

Hmm, instead of sniffing. How about using download attribute as first choice if it's supported? Or is IE's save method still preferred over create object url?

@MartinHlavna
Copy link
Author

MartinHlavna commented Dec 22, 2016

Well, I think It is good to remain using IE's save method for now if it is possible. We will see if the download attribute in next update will really be fixed and how stable the fix will be. If it will be good then this may be a good idea.

But the problem may be Edge / IE users that dont upgrade as they will be saving with the UUID as the name.

@Ruffio
Copy link

Ruffio commented Jul 29, 2017

Should this issue be merged?

@ThomasPe
Copy link

ThomasPe commented Dec 6, 2017

This would be great!

@eligrey
Copy link
Owner

eligrey commented Dec 15, 2017

Yeah, I will merge this. It looks like it needs rebased though.

@MartinHlavna
Copy link
Author

I will look onto rebasing as soon as I can

@Ruffio
Copy link

Ruffio commented Mar 7, 2018

@MartinHlavna how is the rebasing going?

@MartinHlavna
Copy link
Author

I didn't have time first and then forgot about it. Thanks for bringing this up.

@Ruffio
Copy link

Ruffio commented Mar 17, 2018

@MartinHlavna how is the rebasing going?

@Ruffio
Copy link

Ruffio commented Jun 6, 2018

@eligrey this PR should be rejected as it is incomplete and author has failed to respond for three months...

@jimmywarting jimmywarting mentioned this pull request Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants