Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Its not possible to create a DM or invite a user with a full MXID on a new account #1500

Closed
pixlwave opened this issue Aug 16, 2023 · 2 comments
Assignees
Labels
A-Authentication O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@pixlwave
Copy link
Member

pixlwave commented Aug 16, 2023

Steps to reproduce

  1. Use OIDC to create a new account.
  2. Click the prominent Start Chat button.
  3. Enter a full mxid to tell your colleague "wooo, it worked, I'm signed into Element"

Outcome

What did you expect?

To be able to start a chat.

What happened instead?

Simulator Screen Recording - iPhone 14 - 2023-08-16 at 15 14 02

Homeserver Ts & Cs not accepted.

2023-08-16T14:00:42.162374Z DEBUG root:send{homeserver="https://my.homeserver/" server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6] config=RequestConfig { timeout: 30s } request_id="REQ-27" request_size="197 B" path="/_matrix/client/v3/createRoom" status=403 response_size="389 B"}: matrix_sdk::http_client: crates/matrix-sdk/src/http_client/mod.rs:208: Error while sending request: Api(Server(ClientApi(Error { status_code: 403, authenticate: None, body: Standard { kind: _Custom { errcode: "M_CONSENT_NOT_GIVEN", extra: Extra({"consent_uri": String("https://my.homeserver/_matrix/consent?u=myuserid&h=6757a23ece6b4347206dabe6eadd5cf652ac75db4ca10af5061ca1b83151ebd3")}) }, message: "To continue using this homeserver you must review and agree to our terms and conditions at https://my.homeserver/_matrix/consent?u= myuserid&h=6757a23ece6b4347206dabe6eadd5cf652ac75db4ca10af5061ca1b83151ebd3." } })))

Your phone model

Simulator

Operating system version

16.4

Application version

1.2.4 develop

Homeserver

element.io

Will you send logs?

No

@hughns hughns self-assigned this Aug 16, 2023
@hughns
Copy link
Member

hughns commented Aug 16, 2023

I believe this is a server configuration problem rather than something that an OIDC native client should handle. I will clarify and confirm.

@pixlwave pixlwave added A-Authentication S-Critical Prevents work, causes data loss and/or has no workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 23, 2023
@hughns
Copy link
Member

hughns commented Oct 6, 2023

The homeserver shouldn't be using the consent feature of the Matrix Client-Server API and instead it should be handled by the OIDC Provider.

This is now enforced in Synapse by matrix-org/synapse#16127 which is included in >=1.91.0.

@hughns hughns closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Authentication O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants