Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical rooms is always empty #7850

Open
bwindels opened this issue Dec 13, 2018 · 7 comments
Open

Historical rooms is always empty #7850

bwindels opened this issue Dec 13, 2018 · 7 comments
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@bwindels
Copy link
Contributor

bwindels commented Dec 13, 2018

On riot-web, "Historical rooms" section in the left panel always says "You have no historical rooms" (often after showing a spinner for a while). @bmarty says there is also no lazy loading for this request, another filter is used in a parallel /sync. There is no lazy_load_members argument in this filter

@bmarty
Copy link
Member

bmarty commented Dec 13, 2018

@lampholder
Copy link
Member

@bwindels does this mean the historical rooms feature has been broken since lazy loading? (And nobody's noticed?)

@lampholder lampholder added T-Defect P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Dec 13, 2018
@bwindels
Copy link
Contributor Author

@lampholder I'm unsure whether the breakage is related to lazy loading or not. As part of finding it broken Benoit mentioned it should lazy load members as well.

@turt2live
Copy link
Member

As a data point: in my history of using riot, it has never worked.

@thomas-profitt
Copy link

I'm having this problem too.

  1. I leave some rooms in Riot, and the rooms immediately appear in Historical.
  2. I refresh the page
  3. I click Historical
  4. The spinner spins.
  5. The "You have no historical rooms" message is shown.

Monitoring HTTP requests in the browser debugging tools, I can see Riot updating Filter 1 with "include_leave": true, but sync requests are passing filter=7, and sending a GET request for Filter 7 shows that it doesn't have "include_leave": true

@dr1
Copy link

dr1 commented Apr 2, 2019

I have been having this bug for awhile now. It stopped working about the time my IRC appservice didnt want to let me leave a room, and I had to manually edit myself out. Didnt touch the matrix DB, so don't know if related, but it wasnt long after that I noticed historical rooms were gone. Now they do exactly what thomas mentions above.

@Wodann
Copy link

Wodann commented May 29, 2022

This is still a problem for left rooms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

7 participants