[OSX][QWERTY] Emphasized character preceded by the unaccented character

[Arubinu]

Description

Hello, I use a Macbook Pro with Qwerty keyboard. When I want to write an accented character, a box offers me to choose after a long press. The trouble is that the accented character added later is preceded by the character without accent.

Steps to reproduce

• Long press on the E key: displays the selection box of the accent (possibility to use the numbers of the keyboard to choose).
• Before the choice, the letter is already displayed.
• Once the letter É chosen, it is added to the continuation, example in French: Ce texte comporte des caracteères accentueés et chacun est doubleé aà chaque fois !

In general, the unaccented character is not displayed at all (so it is not deleted later), which makes no duplication.

Version information

• Platform: web (in-browser) and desktop

For the web app:

• Browser: Vivaldi 2.0.1309.29 (Stable channel) (64 bits)
• OS: macOS 10.13 & macOS 10.14
• URL: riot.im/app 0.16.4 & 0.16.5

For the desktop app:

• OS: macOS 10.13 & macOS 10.14
• Version: 0.16.4 & 0.16.5

[lampholder]

Even worse, the accented character seems to be appended to the message text, after the caret (so you'd have to navigate to the end of the text manually to continue typing).

[aaronraimist]

Working on the fix for this

[lampholder]

Excellent news :) In case it's useful (though at this stage I imagine it is not), this problem is not inherent to draft.js (the demo draft.js at https://draftjs.org/ works fine).

[lampholder]

Oh, and just to save anyone else who's looking into this a Google - if like me you'd turned this feature off so long ago you'd forgotten it existed, you can toggle it with

defaults write -g ApplePressAndHoldEnabled -bool false

(or true, obvs)

[Arubinu]

It still does not work for me with the latest version (riot-web: 0.16.5, olm: 2.2.1).

[aaronraimist]

This issue can be closed, fixed now in v0.17.0 and later.

[turt2live]

@Arubinu @lampholder are you able to confirm if this is fixed? I don't have a mac to test with unfortunately.

[lampholder]

I'm afraid this still seems to be broken on latest /develop (ca30539-react-cf31f01c8584-js-62b2c07be2fa):

[aaronraimist]

Ohh 😟
It got fixed in Firefox and Safari but is still broken in Chrome

[aaronraimist]

?? I could have sworn it wasn't an upstream bug before but today I can reproduce it on slatejs.org in Firefox and Chrome (but not Safari)

[turt2live]

I'm going to trust that this is an upstream issue - if it's not, well, bleh :(

[turt2live]

Closing in favour of #7665 to track the upstream issue.