Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinner doesn't appear in timeline anymore when reconnecting after error #7261

Closed
bwindels opened this issue Sep 3, 2018 · 3 comments
Closed

Spinner doesn't appear in timeline anymore when reconnecting after error #7261

bwindels opened this issue Sep 3, 2018 · 3 comments
Labels
A-Lazy-Loading

Comments

@bwindels
Copy link
Contributor

bwindels commented Sep 3, 2018 •
edited
Loading

We no longer show a spinner when recovering after losing connectivity (e.g. after being slept). Superficially this looks like the catchup has entirely failed, as the client lets you send messages, but there's no evidence that the client doesn't think it's caught up. This might be the same as the previous "RR suddenly jump" bug? (if RR are the only things to have changed position after having caught up). In practice, though, it's still trying to reconnect. Rageshake. It looks like this:

screen shot 2018-08-17 at 23 34 19
@bwindels bwindels mentioned this issue Sep 3, 2018
Closed
@bwindels
Copy link
Contributor Author

bwindels commented Sep 3, 2018

Split of from #7182

@bwindels
Copy link
Contributor Author

bwindels commented Sep 3, 2018

PR: matrix-org/matrix-js-sdk#702

@ara4n
Copy link
Member

ara4n commented Sep 8, 2018

hm, can we not close this now if the fix merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Lazy-Loading
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwindels @ara4n