Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stickerpicker doesn't load stickers during scrolling, only once scrolling stops #6443

Closed
ara4n opened this issue Apr 3, 2018 · 5 comments
Closed
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Apr 3, 2018

This means you can't scroll through the list of stickers to find the one you're looking for, as whilst you scroll, the images don't update and you only see placeholders. You have to actively release the mouse and stop scrolling to let the images load, which is quite unintuitive. Instead, i'd suggest (ratelimitedly) lazyloading in images whilst you scroll - or at least let them load when you pause scrolling.

@Cadair
Copy link

Cadair commented Apr 4, 2018

I appear to be unable to reproduce this on Firefox (while clicking and dragging on the scroll bar)

@dali99
Copy link
Contributor

dali99 commented Apr 4, 2018

Can't reproduce on firefox either, scrolling with the scrollwheel and scrolling with by dragging bar. It loads really slowly though (which is odd seeing as the images are cached and load with 0ms delay according to FF network analysis) so it sort of looks like it doesn't load.

@lampholder
Copy link
Member

I can't currently verify this due to stickerpack UX being otherwise broken.

@ara4n @rxl881 - is this a blocker for sticker packs going live?

@lampholder lampholder added T-Defect ui/ux P1 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Apr 16, 2018
@rxl881
Copy link
Contributor

rxl881 commented Apr 16, 2018

It shouldn't be a blocker. Once the "persistent context menu" for the sticker picker has been implemented the initially visible stickers will be loaded (while the contextual menu is hidden) on initial riot load (ready for when it is made visible).

We may choose to rate limit pre-loading of all other (non-visible) sticker thumbnails, which will be trivial once we're at that stage, but it's certainly not a blocker on release, IMHO.

@rxl881
Copy link
Contributor

rxl881 commented Jun 7, 2018

This should now be fixed. Stickers are now lazy-loaded (rate-limited) in the background once the sticker picker has initially been added to the DOM (e.g. after first opening), regardless of whether stickers are visible or not.

@rxl881 rxl881 closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants